Fix container python call in build script#10
Merged
weihuang-jedi merged 1 commit intoNOAA-EPIC:feature/use_container_prefixfrom Feb 10, 2026
Conversation
Builds were failing in the container because the build script arguments were being inadvertently passed to the python env script. Eliminated this by placing the line that sources the script inside a dummy function.
weihuang-jedi
approved these changes
Feb 10, 2026
Collaborator
weihuang-jedi
left a comment
There was a problem hiding this comment.
Thanks for fixing this "bug".
It is not an issue for hosts, but a problem for container.
7ed8359
into
NOAA-EPIC:feature/use_container_prefix
2 of 4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Builds were failing in the container because the build script arguments were being inadvertently passed to the python env script. Eliminated this by placing the line that sources the script inside a dummy function.
Type of change
Change characteristics
How has this been tested?
GFS build in container on Ursa
Checklist