Skip to content

Comments

Fix container python call in build script#10

Merged
weihuang-jedi merged 1 commit intoNOAA-EPIC:feature/use_container_prefixfrom
WalterKolczynski-NOAA:feature/use_container_prefix
Feb 10, 2026
Merged

Fix container python call in build script#10
weihuang-jedi merged 1 commit intoNOAA-EPIC:feature/use_container_prefixfrom
WalterKolczynski-NOAA:feature/use_container_prefix

Conversation

@WalterKolczynski-NOAA
Copy link

@WalterKolczynski-NOAA WalterKolczynski-NOAA commented Feb 10, 2026

Description

Builds were failing in the container because the build script arguments were being inadvertently passed to the python env script. Eliminated this by placing the line that sources the script inside a dummy function.

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this change expected to change outputs (e.g. value changes to existing outputs, new files stored in COM, files removed from COM, filename changes, additions/subtractions to archives)? NO
  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO

How has this been tested?

GFS build in container on Ursa

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

Builds were failing in the container because the build script arguments
were being inadvertently passed to the python env script. Eliminated
this by placing the line that sources the script inside a dummy function.
Copy link
Collaborator

@weihuang-jedi weihuang-jedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this "bug".
It is not an issue for hosts, but a problem for container.

@weihuang-jedi weihuang-jedi merged commit 7ed8359 into NOAA-EPIC:feature/use_container_prefix Feb 10, 2026
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants